This repository has been archived by the owner on Dec 1, 2019. It is now read-only.
feat: pass ts.Program as an argument for getCustomTransformers #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimamula
commented
Jun 21, 2018
| @@ -433,7 +433,8 @@ function createChecker(receive: (cb: (msg: Req) => void) => void, send: (msg: Re | |||
| const trans = compiler.transpileModule(files.get(fileName).text, { | |||
| compilerOptions: compilerOptions, | |||
| fileName, | |||
| reportDiagnostics: false | |||
| reportDiagnostics: false, | |||
| transformers: finalTransformers ? finalTransformers(getProgram().getProgram()) : undefined | |||
There was a problem hiding this comment.
It is likely this line was accidentally removed in 38a772f.
See #531 (comment).
|
@kimamula thanks! |
|
@kimamula Why pass ts.Program? rollup-plugin-typescript2 pass ts.LanguageService. |
|
Because it was easier to implement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables using custom transformers which require
ts.Program.The feature has been already supported by rollup-plugin-typescript2.