Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(parser): remove lint warning related to 'try' usage #13

Merged
merged 2 commits into from Jun 6, 2020
Merged

refactor(parser): remove lint warning related to 'try' usage #13

merged 2 commits into from Jun 6, 2020

Conversation

jayaddison
Copy link
Contributor

This change eliminates a compile-time lint warning; the indicated try! macro is removed, and an ? operator is introduced instead.

warning: use of deprecated item 'try': use the `?` operator instead
   --> src/parser.rs:179:29
    |
179 |         let parse_key_res = try!(parse_key(key));

@GitCop
Copy link

GitCop commented May 11, 2020

There were the following issues with your Pull Request

  • Commit: 27e8681

  • Commits must be in the following format: %{type}(%{scope}): %{description}

  • Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

  • Commit: 4592161

  • Commits must be in the following format: %{type}(%{scope}): %{description}

  • Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/rustless/queryst/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@jayaddison jayaddison changed the title Cleanup: remove lint warning related to 'try' usage refactor(*): remove lint warning related to 'try' usage May 11, 2020
@jayaddison jayaddison changed the title refactor(*): remove lint warning related to 'try' usage refactor(parser): remove lint warning related to 'try' usage May 11, 2020
@s-panferov s-panferov merged commit d7f305c into s-panferov:master Jun 6, 2020
@jayaddison jayaddison deleted the cleanup/try-warning branch November 9, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants