Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Support for bullmq ? #35

Closed
mannharleen opened this issue Oct 19, 2021 · 7 comments
Closed

Support for bullmq ? #35

mannharleen opened this issue Oct 19, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@mannharleen
Copy link

Is there a plan to support bullmq?

@s-r-x
Copy link
Owner

s-r-x commented Oct 19, 2021

@mannharleen hello. unfortunately, i don't use bullmq in production, so this one is not my highest priority atm. PRs are welcome, though!

@s-r-x s-r-x added enhancement New feature or request help wanted Extra attention is needed labels Oct 19, 2021
@mannharleen
Copy link
Author

do you reckon that the changes would mostly involve creating another class for BullMQ and implementing all that is here - https://github.com/s-r-x/bull-monitor/blob/main/packages/root/src/gql/data-sources/bull/index.ts

@s-r-x
Copy link
Owner

s-r-x commented Oct 19, 2021

@mannharleen, don't think so. the main problem is that there is no abstraction over Queue class, and it is used as it is all over the place. For example, there is the text search class, that heavily relies on bull internals. One way to solve it is to wrap user defined queues in some kind of adapter. Otherwise if bull and bullmq apis are quite similar i guess you can patch the differences here and there using instanceof. Anyways bullqueue type should be changed everywhere from bullqueue to somequeueadapter in the first case, and to bullqueue | bullmqqueue in the second one. Which is helluva refactor

@mannharleen
Copy link
Author

Understand. That sounds like a lot of rework 🤔

@s-r-x s-r-x added the wontfix This will not be worked on label Dec 6, 2021
@ccollie
Copy link

ccollie commented Dec 16, 2021

@mannharleen what specifically are you looking for ? I imagine you've looked at bull-board which supports bullmq. Is there something missing in bull-board as well ?

@s-r-x s-r-x linked a pull request Dec 27, 2021 that will close this issue
@s-r-x s-r-x removed help wanted Extra attention is needed wontfix This will not be worked on labels Dec 27, 2021
@s-r-x
Copy link
Owner

s-r-x commented Jan 11, 2022

added in 3.0.0

@s-r-x s-r-x closed this as completed Jan 11, 2022
@mannharleen
Copy link
Author

Thanks mate

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants