Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compression detection can fail for XZ in tar signing #29

Closed
s-u opened this issue Dec 5, 2022 · 1 comment
Closed

compression detection can fail for XZ in tar signing #29

s-u opened this issue Dec 5, 2022 · 1 comment
Assignees
@s-u
Labels
bug

Comments

@s-u
Copy link
Owner

s-u commented Dec 5, 2022

Reported by Debian builds under C.UTF-8 locale test can fail with:

 -- Tar ball signing
Error in eval(ei, envir) : 
  (converted from warning) input string '<fd>7zXZ' cannot be translated to UTF-8, is it valid in 'ANSI_X3.4-1968'?

There are few issues - the magic headers compared in PKI.sign.tar and PKI.verify.tar is too short and the use of strings for the magic contents can break when attempts to interpret it as UTF-8 are made.
@s-u s-u added the bug label Dec 5, 2022
@s-u s-u self-assigned this Dec 5, 2022
s-u added a commit that referenced this issue Dec 5, 2022
@s-u
fix tar ball compression detection (#29)
d6e42a4
@s-u
Copy link
Owner Author

s-u commented Dec 5, 2022

Ok, now fixed. It is unclear why this was only triggered on Debian-11 but not on Ubuntu GHA.

@s-u s-u closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s-u s-u

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s-u