Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: make new dbOption for use.label #102

Open
pgramme opened this issue Feb 1, 2023 · 1 comment
Open

FR: make new dbOption for use.label #102

pgramme opened this issue Feb 1, 2023 · 1 comment

Comments

@pgramme
Copy link

pgramme commented Feb 1, 2023

Hello

As mentioned in #61 and #74, some drivers don't respect JDBC specs about column names vs column labels. The fix you proposed and implemented works fine! (tested for Sas) However, as a user, it is annoying to repeat the parameter at each call to dbFetch/dbGetQuery.

Would you agree to make a new dbOption (e.g. "fetch.use.label") to control the default value per driver or per connection?

I think it only requires modifying the 2 following lines, in dbGetQuery and fetch, and documenting.

I'm happy to propose a PR if it helps

Thanks
Pierre

@pgramme
Copy link
Author

pgramme commented Feb 1, 2023

Related issue by the way: in function JDBC(), options=opts should be passed down to the new("JDBCDriver", ...) call in all of the 3 cases. Currently only done in first case

@pgramme pgramme changed the title FR: make new dbOption for use.labels FR: make new dbOption for use.label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant