Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeting for Google+, microformats Schema.org duplicate when there is a rerender #18

Closed
definder opened this issue Aug 28, 2018 · 2 comments

Comments

@definder
Copy link

When there is first render we have:

<title>Sites's title</title>
<meta itemprop="name" content="Site's name"/>

But when there is second render we have (first meta tag did'n remove):

<meta itemprop="name" content="Site's name"/>
<title>Sites's title 2</title>
<meta itemprop="name" content="Site's name 2"/>

My render function:

render(){
   const {title} = this.props;
    return (
        <MetaTags>
            {!!title && (
                <React.Fragment>
                    <title>{title}</title>
                    <meta itemProp="name" content={title}/>
                </React.Fragment>
            )}
        </MetaTags>
    );
}
@s-yadav
Copy link
Owner

s-yadav commented Sep 1, 2018

Because itemprop is not used to find duplicates. Will check this out.

@s-yadav
Copy link
Owner

s-yadav commented Sep 2, 2018

Fixed in v0.5.0. Let me know if issue still persist.

@s-yadav s-yadav closed this as completed Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants