Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token leaks #60

Closed
s0lst1ce opened this issue Jun 29, 2019 · 1 comment
Closed

Token leaks #60

s0lst1ce opened this issue Jun 29, 2019 · 1 comment
Assignees
@s0lst1ce
Labels
bug Something isn't working quality all issues which only affect the way code is written and that won't affect functionnality

Comments

@s0lst1ce
Copy link
Collaborator

Describe the bug
During development it is easy to forget to remove the TOKEN value in settings.py. This is a big security issue.
This is also unpractical since it is required to access the host to append the TOKEN for the bot to run.

Expected behavior
Changing settings.py should not require one to remove the token before committing.

Additional context
This could be easily fixed by using environment variables.
@s0lst1ce s0lst1ce added bug Something isn't working quality all issues which only affect the way code is written and that won't affect functionnality labels Jun 29, 2019
@s0lst1ce s0lst1ce added this to the v1.1 -- Todo update milestone Jun 29, 2019
@s0lst1ce s0lst1ce self-assigned this Jun 29, 2019
@s0lst1ce
Copy link
Collaborator Author

Fixed with 88fc74d

@s0lst1ce s0lst1ce modified the milestones: v1.1 -- Todo update, v2 Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s0lst1ce s0lst1ce

Labels
bug Something isn't working quality all issues which only affect the way code is written and that won't affect functionnality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s0lst1ce