Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #98

Closed
fabaff opened this issue Nov 17, 2018 · 4 comments
Closed

Release #98

fabaff opened this issue Nov 17, 2018 · 4 comments

Comments

@fabaff
Copy link
Contributor

fabaff commented Nov 17, 2018

Hmm, PyPI tell me that the latest release is 1.1.9. The changelog says it's 1.1.4 (I assume that the changelog wasn't updated) and the latest release on GitHub is 1.1.5.

Also, it seems that the setup.py file is missing.

Usually, I don't care where the package source is coming from (the Fedora Package guidelines don't make a statement about that) but I would be nice if it doesn't change too often.

@s0md3v
Copy link
Owner

s0md3v commented Nov 17, 2018

Well, Photon is on 1.1.5 right now but the changelog wasn't updated after 1.1.4.

When I uploaded Photon to PyPi, I was quite new to PyPi and I messed up. I deleted the build from there and tried to upload it again which ofc failed because PyPi doesn't allow you to upload the same version so I uploaded it again after fixing what I think was causing the trouble and it didn't work again so I uploaded it with +1 version number and......we are here, on 1.1.9.

@fabaff
Copy link
Contributor Author

fabaff commented Nov 17, 2018

I see. It would be nice if they are synced 😉

BTW, thanks for your quick response.

@fabaff fabaff mentioned this issue Nov 17, 2018
@s0md3v s0md3v closed this as completed Nov 20, 2018
@fabaff
Copy link
Contributor Author

fabaff commented Nov 20, 2018

This is not resolved.

@s0md3v
Copy link
Owner

s0md3v commented Nov 20, 2018

There's only one way to resolve this.
PyPi release is at 1.1.9 while Github release is at 1.1.5, so now when 1.1.6 comes out, we can name PyPi release 1.1.9.1 and we can keep doing this until we reach 1.1.10 where we can finally merge them.

Do you have a better idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants