Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add macos support #16

Open
dkbast opened this issue Nov 26, 2023 · 3 comments
Open

[Feature] Add macos support #16

dkbast opened this issue Nov 26, 2023 · 3 comments

Comments

@dkbast
Copy link

dkbast commented Nov 26, 2023

From my understanding, contacts is available on mac (and various other apple OSes) - I believe it would be great if we could also support macos - I suspect that this should be possible using the shared implementations "darwin" flag, that would require a minimum version of Flutter 3.7, so might be a "major" version increment for fast_contacts, or copy pasting the code into macos? I tried getting darwin to work, but the mix of "todays" Flutter and the ios implementation was too much for a quick 15 minute tinkering session.

If you can point me in the right direction I would love to assist :)

https://developer.apple.com/documentation/contacts

@s0nerik
Copy link
Owner

s0nerik commented Nov 27, 2023

This should be quite easy. I'll look into it when I have some spare time. Increasing the minimum flutter version for a next plug-in version should not be a problem as well.

@dkbast
Copy link
Author

dkbast commented Nov 27, 2023

I actually managed to get it to work on a mac only spike - two might be issues: permission handler does not support mac yet (PR seems to be open), so I had to bale that in and there are different imports for mac and ios needed - not sure how to solve that yet - but should be doable.
Will push my proof of concept soonish

@dkbast
Copy link
Author

dkbast commented Nov 27, 2023

@s0nerik - this is my "working poc" for a mac implementation - only minor changes, mostly copy paste from ios:
https://github.com/dkbast/fast_contacts_mac

An implementation without its own permission handling would depend on Baseflow/flutter-permission-handler#1207 to land

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants