Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit find match and word highlight colors #20

Open
svipas opened this issue Nov 2, 2023 · 0 comments
Open

Revisit find match and word highlight colors #20

svipas opened this issue Nov 2, 2023 · 0 comments

Comments

@svipas
Copy link
Contributor

svipas commented Nov 2, 2023

While I was working on #10 fix I noticed that highlighting for find match and words aren't good and hard to see. I checked VS Code's dark theme and GitHub theme and they are doing better job.

Keys:

      "editor.findMatchBackground": "#ff0000",
      "editor.findMatchHighlightBackground": "#ff0000",
      "searchEditor.findMatchBackground": "#ff0000",
      "editorOverviewRuler.findMatchForeground": "#ff0000",
      "editor.wordHighlightBackground": "#ff0000",
      "editor.wordHighlightStrongBackground": "#ff0000",
      "editor.wordHighlightTextBackground": "#ff0000",
      "editorOverviewRuler.wordHighlightForeground": "#ff0000",
      "editorOverviewRuler.wordHighlightStrongForeground": "#ff0000",
      "editorOverviewRuler.wordHighlightTextForeground": "#ff0000"
     // Also, there are borders, but they look weird - we should use it only in case if there's no way to fix it properly

I tried to fix it, but it isn't so easy, because it's hard to find color + opacity which matches theme colors and looks easy to read. So for now let's keep this issue open as a tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant