Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalize Object State Machine and Recovery Logic #364

Closed
irq0 opened this issue Mar 2, 2023 · 2 comments
Closed

Formalize Object State Machine and Recovery Logic #364

irq0 opened this issue Mar 2, 2023 · 2 comments
Assignees
Labels
area/rgw-sfs RGW & SFS related kind/documentation Improvements or additions to documentation kind/enhancement Change that positively impacts existing code kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API

Comments

@irq0
Copy link
Contributor

irq0 commented Mar 2, 2023

What needs to be done

To define recovery logic and error handling we need to formalize the object state machine, especially the transitions and tasks that must happen when a data path encounters an object in a state.

We have the following object states:
OPEN,
WRITING,
COMMITTED,
LOCKED,
DELETED,

Example Error Conditions:

Crash during atomic writer leaves an object in OPEN/WRITING. When a client retries, what happens to the old object. Do we resume? Do we delete it? Do we create a new one? Does the GC clean up OPEN/WRITING after a while?

Client starts a PUT, but disappears mid transfer timing out the connection.

Why it needs to be done

Acceptance Criteria

Additional Information

@irq0 irq0 added kind/documentation Improvements or additions to documentation kind/enhancement Change that positively impacts existing code kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API area/rgw-sfs RGW & SFS related labels Mar 2, 2023
@irq0 irq0 self-assigned this May 8, 2023
@irq0
Copy link
Contributor Author

irq0 commented May 8, 2023

@jhmarina jhmarina added the triage/waiting Waiting for triage label Jun 6, 2023
@jhmarina jhmarina changed the title [Backlog] Formalize Object State Machine and Recovery Logic Formalize Object State Machine and Recovery Logic Jun 6, 2023
@jhmarina
Copy link
Contributor

jhmarina commented Jun 6, 2023

This has already been addressed

@jhmarina jhmarina closed this as completed Jun 6, 2023
@jhmarina jhmarina removed the triage/waiting Waiting for triage label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rgw-sfs RGW & SFS related kind/documentation Improvements or additions to documentation kind/enhancement Change that positively impacts existing code kind/quality Quality improvements, Refactoring, Automation via CI, E2E, Integration, CLI or REST API
Projects
None yet
Development

No branches or pull requests

2 participants