Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubernetes configs. #25

Closed
4 tasks done
s3rius opened this issue Oct 1, 2021 · 4 comments · Fixed by #27
Closed
4 tasks done

Fix kubernetes configs. #25

s3rius opened this issue Oct 1, 2021 · 4 comments · Fixed by #27

Comments

@s3rius
Copy link
Owner

s3rius commented Oct 1, 2021

Currently we have several problems in kubernetes configs.

  • migrator job doesn't have limits on cpu and ram;
  • redis env value converted to boolean after formatting;
  • wrong indent in yamls;
  • invalid format for CMD in Dockerfile.

If you find more, please fell free to add comments.

@azzeph
Copy link

azzeph commented Oct 1, 2021

need to specified namespace what been used to deploying app, it is customary to use like application name
command line for running application need move in Dockerfile difference between cmd and entrypoint https://stackoverflow.com/questions/21553353/what-is-the-difference-between-cmd-and-entrypoint-in-a-dockerfile
something ugly happened with spaces in spec.rules :) i'm use 2 spaces in k8s manifests and its look absolutely readable and have more compact look

in Docker file cmd and entrypoint is customary to use in format CMD [''/bin/bash', '-c' "/opt/app/test.sh" ] rly good idea use absolute files name

@azzeph
Copy link

azzeph commented Oct 1, 2021

need to specified namespace what been used to deploying app, it is customary to use like application name command line for running application need move in Dockerfile difference between cmd and entrypoint https://stackoverflow.com/questions/21553353/what-is-the-difference-between-cmd-and-entrypoint-in-a-dockerfile something ugly happened with spaces in spec.rules :) i'm use 2 spaces in k8s manifests and its look absolutely readable and have more compact look

in Docker file cmd and entrypoint is customary to use in format CMD [''/bin/bash', '-c' "/opt/app/test.sh" ] rly good idea use absolute files name

and need add opportunity to choice trafic routing for pod, clusterip, nodeport loadblanacer.

@s3rius
Copy link
Owner Author

s3rius commented Oct 1, 2021

@azzeph, I have added some issues you mentioned, but I don't think that adding switchable traffic routing is a feature that we need. Because it's relatively easy to change it by hand.

Also what do you think about helm charts? They are quite popular out there. Maybe it would be nice to generate one.

@s3rius s3rius closed this as completed in #27 Oct 2, 2021
s3rius added a commit that referenced this issue Oct 2, 2021
Closes #25.

Signed-off-by: Pavel <win10@list.ru>
@s3rius
Copy link
Owner Author

s3rius commented Oct 2, 2021

Fixed in version 3.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants