Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servers merge #96

Open
awhitford opened this issue Feb 16, 2021 · 1 comment
Open

servers merge #96

awhitford opened this issue Feb 16, 2021 · 1 comment
Labels
enhancement New feature or request. to grab Ready to do and to grab by those willing.

Comments

@awhitford
Copy link
Contributor

The setup-java action provides support for configuring a settings.xml:

    - name: Set up Apache Maven Central
      uses: actions/setup-java@v1
      with: # running setup-java again overwrites the settings.xml
        java-version: 1.8
        server-id: maven # Value of the distributionManagement/repository/id field of the pom.xml
        server-username: MAVEN_USERNAME # env variable for username in deploy
        server-password: MAVEN_CENTRAL_TOKEN # env variable for token in deploy
        gpg-private-key: ${{ secrets.MAVEN_GPG_PRIVATE_KEY }} # Value of the GPG private key to import
        gpg-passphrase: MAVEN_GPG_PASSPHRASE # env variable for GPG private key passphrase

One should be able to use this action to update settings.xml. I believe the two options are skip and override, but ideally there is a merge option too so that one could use this action to add a new server record to an existing settings.xml.

@slawekjaranowski slawekjaranowski added the enhancement New feature or request. label Feb 18, 2021
@slawekjaranowski
Copy link
Member

use case to testing with change for beginning:

  • no existing settings.xml - should create standard setting provided by action
  • no existing servers tag in settings.xml
  • existing server tag with the same id - should throw exception

@slawekjaranowski slawekjaranowski added the to grab Ready to do and to grab by those willing. label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. to grab Ready to do and to grab by those willing.
Development

No branches or pull requests

2 participants