Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redis to be configured with password #51

Closed
pdxrlj opened this issue May 12, 2023 · 3 comments
Closed

Allow redis to be configured with password #51

pdxrlj opened this issue May 12, 2023 · 3 comments
Labels
enhancement New feature or request test required

Comments

@pdxrlj
Copy link

pdxrlj commented May 12, 2023

package main

import (
	"fmt"

	flow "github.com/s8sg/goflow/flow/v1"
	goflow "github.com/s8sg/goflow/v1"
)

// Workload function
func doSomething(data []byte, option map[string][]string) ([]byte, error) {
	fmt.Printf("hello world\n")
	return []byte(fmt.Sprintf("you said \"%s\"", string(data))), nil
}

// Define provide definition of the workflow
func DefineWorkflow(workflow *flow.Workflow, context *flow.Context) error {
	dag := workflow.Dag()
	dag.Node("test", doSomething)
	return nil
}

func main() {
	fs := &goflow.FlowService{
		Port:              8080,
		RedisURL:          "192.168.1.65:16379", // need redis password 123
		OpenTraceUrl:      "192.168.1.65:5775",
		WorkerConcurrency: 5,
		EnableMonitoring:  true,
	}

	fs.Register("myflow", DefineWorkflow)
	fs.Start()
}
@s8sg
Copy link
Owner

s8sg commented May 17, 2023

I think we should have a way to define the redistribution configuration.
For now you can follow the go flow getting started instructions

Let me change the issue as an enhancement to support redis user/password

@s8sg s8sg changed the title redis needs a password how to connect Allow redis to be configured with password May 17, 2023
@s8sg s8sg added the enhancement New feature or request label May 17, 2023
@s8sg
Copy link
Owner

s8sg commented Jun 21, 2023

#59 Needs to be tested

@s8sg
Copy link
Owner

s8sg commented Jun 22, 2023

Completed

@s8sg s8sg closed this as completed Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test required
Projects
None yet
Development

No branches or pull requests

2 participants