-
Notifications
You must be signed in to change notification settings - Fork 9
Add to Packagist, add Composer installation instructions #3
Comments
Uploading to Packagist/ installing via Composer also enables you to remove the "version" line from composer.json, as Packagist automatically gets this information from git tags and Flarum automatically gets this information from vendor/composer/installed.json. |
Yeah, actually I did that a few minutes ago but I had to remove it from Packagist when I saw that it installed a snapshot from the tree rather than the release file. The difference between the two is that a snapshot from the tree contains my build script, and I don't want people to inadvertently install executable files. Is there a way to tell Packagist to specifically use the release file? |
Ah I see. I think if you add |
Also keep in mind that we intend to prevent public web access to the extensions directory. The default .htaccess and the provided nginx configuration don't currently do this but they should/will when I get around to it. So executables in extensions won't be a problem. That said, do you really need a build script if distributing via Packagist? |
Alright, I've just checked and the latest version only installs the necessary files via Composer. Everything should work as expected. |
We want to expose people to the idea of using Composer to install extensions. While a zip download is fine for extensions like this without any autoloading stuff, it'd be cool if you could put this up on Packagist and add
composer require s9e/flarum-mediaembed
as an alternative method of installation to the README. This would certainly be my preferred method of installation for discuss.flarum.org! And then updates are as easy ascomposer update
👍I'm not sure if you can use a different package name on Packagist, but Flarum's Composer installer only truncates a
flarum-
prefix from the start, so ideally the package name would beflarum-mediaembed
. That would be installed toextensions/s9e-mediaembed
.The text was updated successfully, but these errors were encountered: