Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Add animated class to animated buttons #1022

Closed
28 tasks done
shahednasser opened this issue Oct 30, 2020 · 74 comments
Closed
28 tasks done

Add animated class to animated buttons #1022

shahednasser opened this issue Oct 30, 2020 · 74 comments
Labels
Always Open Always accepting changes buttons Changes or fixes to buttons enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Priority: High Items that need immediate attention up-for-grabs

Comments

@shahednasser
Copy link
Collaborator

shahednasser commented Oct 30, 2020

Most animated button's animation only happens on hover, we need to add an animated class that triggers the animation without hovering over the button. And when the animation class is added make sure that the animation is not also triggered on hover. In order to avoid repeated code in the buttons, please move the animation or transition to a mixin and call it where it is needed.

Also, some button's animation needs to be continuous, others don't. I have indicated below which is continuous and which isn't

This issue is going to be split between contributors. Each contributor can take up a button from the list below. Please comment before taking up a button, choosing which between you will be working on.

The following buttons need the animated class:

@shahednasser shahednasser added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers Always Open Always accepting changes up-for-grabs Priority: High Items that need immediate attention buttons Changes or fixes to buttons labels Oct 30, 2020
@github-actions
Copy link

Hi, @shahednasser,
Thanks for opening an issue 💙 your issue will be seen by maintainers soon.
Contributors 🧑‍🤝‍🧑 like you make the open source community 🌍 such an amazing place to learn 📖 , inspire 👼, and create 🎨 .
We will investigate 👀 and get back to you as soon as possible 👍 .
Just make sure you have given us sufficient information ℹ️.
By that time enjoy this joke 👇 , hope you like it 😄

Why is 6 afraid of 7 in hexadecimal Canada?
Because 7 8 9 A?

Use this action on your projects.

@shahednasser shahednasser pinned this issue Oct 30, 2020
@shahednasser shahednasser added this to To do in Core Features via automation Oct 30, 2020
@karleypetracca
Copy link
Contributor

karleypetracca commented Oct 31, 2020

I will take the atom button. Thanks!

@shahednasser
Copy link
Collaborator Author

Great @karleypetracca you can go ahead

@karleypetracca
Copy link
Contributor

karleypetracca commented Oct 31, 2020

One additional consideration on this @shahednasser : will there be a plan to put something like shouldHaveAnimatedType into the buttons-examples.js? I imagine it would default to false, unless the value is there in the examples list. That way it can be turned on for each button as each new button's .animated css class gets completed, and for those completed buttons, can show the class exists.

I'd be up for adding this functionality if you're comfortable with that. 😃

@shahednasser
Copy link
Collaborator Author

@karleypetracca I don't think it's necessary for the website at the moment, as it could make it laggy. We could maybe decide in the future to do that, but only play the animation when the button is on screen? This is just an idea but I'm not sure we will work on it at the moment, but thank you for the suggestion!

@Hrshk15
Copy link
Contributor

Hrshk15 commented Nov 5, 2020

I'll take the rainbow button.

@shahednasser shahednasser changed the title Added animated class to animated buttons Add animated class to animated buttons Nov 6, 2020
@shahednasser
Copy link
Collaborator Author

Great @Hrshk15 thanks!

@adsingh14
Copy link
Contributor

Indeed !

I've an idea to improve the UI/UX of animated buttons. I can add the toggle animated class functionality in such way that it won't affect the other contributors work. Will discuss this further on your acknowledgement.

@TomWBush
Copy link

TomWBush commented Nov 9, 2020

How many of them can I take? I will take Aura and Bounce if I can take more than one. Thank you!

@shahednasser
Copy link
Collaborator Author

@adsingh14 great but toggle button is not on the list above so please choose one of the buttons from the list and let me know which

@shahednasser
Copy link
Collaborator Author

sure @TomWBush you can

@TomWBush
Copy link

I can take the next three, Diagonal Background on Hover, Expanding Border, Fill Buttons All Types.

One question I have is that Expanding Border does not seem to have a continuous animation on hover. Do you want me to make it continuous for the animated class?

@shahednasser
Copy link
Collaborator Author

Thanks @TomWBush . No I think that was a mistake, it's not supposed to be continuous. I'll edit that.

@adsingh14
Copy link
Contributor

@shahednasser I wasn't talking about toggle button from the list. I was suggesting adding toggle functionality button for animated buttons.

@shahednasser
Copy link
Collaborator Author

@adsingh14 oh do you mean on the website adding a toggle functionality that adds or removes the animated class? That's a good idea. Can you open a new issue with it please with it?

@yuwangcs
Copy link

@shahednasser hello, can I take flash, hinge, invert?

@shahednasser
Copy link
Collaborator Author

Yes @yuwangcs you can

@karishmapatel27
Copy link
Contributor

Hi @shahednasser
I'd like to contribute to this project, may I know which buttons are still available?

@princeo1
Copy link

Hi @shahednasser ,I want to contribute here ,can you let me know which one is available?

@shahednasser
Copy link
Collaborator Author

Hi @kalimah-apps I have assigned you to hinge

@shahednasser
Copy link
Collaborator Author

Hello @karishmapatel27 @princeo1 the ones that are not checked off and do not have next to them "taken by" are available. Please comment which ones you'd like to work on to be assigned to them

@karishmapatel27
Copy link
Contributor

Hi @shahednasser, thank you for coming back to me. I would like to work on Invert please.

@shahednasser
Copy link
Collaborator Author

Great I have assigned you the button

@princeo1
Copy link

Thank you for replying @shahednasser I would like to work on rainbow

@shahednasser
Copy link
Collaborator Author

Great @princeo1 you're assigned

@arnaugomez
Copy link

Hi @shahednasser I'm new to the project and would like to contribute. Please feel free to assign me a task ✅

@shahednasser
Copy link
Collaborator Author

Hi @arnoldgee please choose a button from the list if you want to work on it!

@github-actions
Copy link

github-actions bot commented Mar 5, 2021

@shahednasser reporting a stale issue.

@github-actions github-actions bot added the stale-issue Issue that is inactive label Mar 5, 2021
@shahednasser shahednasser removed the stale-issue Issue that is inactive label Mar 5, 2021
@TanmayJain17
Copy link
Contributor

Hi @shahednasser I would also like to contribute here . Can I work on the Flash Button ?

@shahednasser
Copy link
Collaborator Author

Hello @TanmayJain17 yes you can I'll assign you

@A3vk
Copy link
Contributor

A3vk commented Mar 13, 2021

Hello @shahednasser can I work on the Liquid and the Rainbow button?

@abidahmadq
Copy link
Contributor

Hello @shahednasser can i take these
Rainbow (continuous)
Ripple (not continuous)
Scale (not continuous)
button ?

@shahednasser
Copy link
Collaborator Author

@A3vk I have assigned you Liquid and Rainbow
@Abid1998 I have assigned you Ripple and Scale.

Thank you

@rad10wave
Copy link
Contributor

Hey @shahednasser can i take the Snake Border ?

@shahednasser
Copy link
Collaborator Author

Hello @rad10wave yes I'll assign you

@shahednasser shahednasser unpinned this issue Mar 24, 2021
Core Features automation moved this from To do to Done Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Always Open Always accepting changes buttons Changes or fixes to buttons enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Priority: High Items that need immediate attention up-for-grabs
Projects
Core Features
  
Done
Development

No branches or pull requests