Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing the IE invalid standard 'filter' #1

Closed
splitice opened this issue Nov 5, 2010 · 5 comments
Closed

Parsing the IE invalid standard 'filter' #1

splitice opened this issue Nov 5, 2010 · 5 comments
Labels

Comments

@splitice
Copy link

splitice commented Nov 5, 2010

Most stylesheets I see in production have atleast one DXImageFilter in them, usually for lightboxes and the likes. While they are invalid format (non W3c) I dont think its great to have the parser fail when parsing them, they should be ignored? But hopefully left in the final output so yeah.

An example of what i am talking about is:
filter:progid:DXImageTransform.Microsoft.AlphaImageLoader(src="overlay.png",sizingMethod="scale")}

Any chance you could improve your parser to handle Microsofts proprietary extension?

@sabberworm
Copy link
Contributor

You are right. This is definitely a feature to be considered. The problem is that it’s actually in the CSS specification how to parse invalid CSS while this particular parser only guarantees to parse valid CSS.

@NickStallman
Copy link

jQuery UI uses a number of filter:alpha(opacity=0.7) style rules so that is a lower hanging fruit to target.

@sabberworm
Copy link
Contributor

jQuery UI only produces filter:alpha(opacity=0.7) styles (as inline styles), it does not require the CSS file to contain those styles.

@NickStallman
Copy link

Themes I've made with the ThemeRoller use the filters. E.g. .ui-helper-zfix, .ui-widget-overlay and a few others.

sabberworm added a commit that referenced this issue Aug 30, 2011
… but this value may be a CSSRuleValueList which has a separator and may contain multiple values, which, each, in turn can also be CSSValueLists.

Closes #14 as fixed
References #17
Also adds support for function(key=value) as in msie filter properties (issue #1).
@sabberworm
Copy link
Contributor

I think support for filter: alpha(opacity=xyz); is good enough, we don’t need to support filter:progid:DXImageTransform.Microsoft.AlphaImageLoader(src="overlay.png",sizingMethod="scale")}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants