Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have versioning info in names of release artifacts #331

Closed
fybx opened this issue Feb 10, 2023 · 3 comments
Closed

Have versioning info in names of release artifacts #331

fybx opened this issue Feb 10, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@fybx
Copy link
Contributor

fybx commented Feb 10, 2023

Is your feature request related to a problem? Please describe.
I'm working on an Arch Linux User Repository package for Saber, and artifacts provided in GitHub releases do not contain version information that can make packaging for AUR easier.

Describe the solution you'd like
I thought about providing a pull request to the GitHub action you set for "Build for Linux" but got lost easily. Anyways, I found this workflow: https://github.com/marketplace/actions/github-releases-for-automated-package-publishing that provides variables to utilize the version name in the action itself, such that it would enable us to rename the artifacts generated.

Describe alternatives you've considered
Not applicable

Device (please complete the following information):
Not applicable

Additional context
I will try again with what we currently got in hand when I have the time.

@fybx fybx added the enhancement New feature or request label Feb 10, 2023
@adil192

This comment was marked as outdated.

@adil192
Copy link
Member

adil192 commented Feb 11, 2023

With b3b2e99 I've renamed e.g. Saber-Linux-Portable.tar.gz to Saber_v0.9.1_9010.tar.gz.
Does this fix your issue?

@fybx
Copy link
Contributor Author

fybx commented Feb 11, 2023

Yes, it does. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants