Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some (rasterised) PDFs don't invert properly #628

Closed
adil192 opened this issue May 5, 2023 · 3 comments
Closed

Some (rasterised) PDFs don't invert properly #628

adil192 opened this issue May 5, 2023 · 3 comments
Labels
bug Something isn't working help wanted

Comments

@adil192
Copy link
Member

adil192 commented May 5, 2023

Describe the bug

Some PDFs invert to a completely black rectangle. Other PDFs invert weirdly -- showing outlines of letters and not their fill.

To reproduce

  1. Import a PDF with text in it
  2. Turn on dark mode and inversion
  3. See result like screenshots

Expected behavior

Invert normally

Saber version

v0.12.0 (12010)

Device

  • Device: Google Pixel 6 Pro
  • OS: Android 13

Anything else?

@adil192 adil192 added the bug Something isn't working label May 5, 2023
@adil192
Copy link
Member Author

adil192 commented May 31, 2023

Both of these problems seem to be fixed in v0.12.9, maybe because of upstream flutter fixes or because of 8fe64c2.

@adil192
Copy link
Member Author

adil192 commented May 31, 2023

Nope they're only fixed on my Galaxy Tab S7 (OneUI 5.1/Android 13) but not my Pixel 6 (Android 13)

@adil192
Copy link
Member Author

adil192 commented Dec 24, 2023

Testing image:

(Uninverted) Before After
Uninverted: A thumbnail of some black strokes on a white background, on the home page of Saber Before: Only the outlines of shapes are shown After: The outlines and fill of the shapes are correctly shown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted
Projects
None yet
Development

No branches or pull requests

1 participant