This repository has been archived by the owner on Dec 15, 2020. It is now read-only.
Update permalinks structure #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FanaHOVA
reviewed
Apr 9, 2017
| @@ -1,6 +1,7 @@ | |||
| - if articles && articles.any? | |||
|
|
|||
| - articles.each_with_index do |article, index| | |||
| - article_category = defined?(category) ? category : nil | |||
There was a problem hiding this comment.
Can Articles not have a category?
There was a problem hiding this comment.
@FanaHOVA I don't think such a case would be possible as long as at leas one category is required by Contentful validator.
I understand your confusion, but this statement has nothing about the inexistent category for article ¯_(ツ)_/¯ The main point of having it here is permalinks structure in the current Content Platform implementation, where each article could have several URLs according to selected category (see the issue #22).
There was a problem hiding this comment.
@query-string 👍 sounds good, thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks Middleman URL structure so built directories structure matches current content platform URs.
Belongs to #2194