New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor page interface #345
Conversation
Deploy preview for saber ready! Built with commit 32201c7 |
This is actually a bad UX 🤔It seems using |
This reverts commit 022e71c.
Hmm never mind, let's just use this approach for now, when we have #183 implemented we won't have to inject variables like this. |
Yes for now I rename them to |
If anyone wants to try this PR out, just re-install all your saber-related dependencies from |
Summary
Closes #332
What kind of change does this PR introduce? (check at least one)
If changing the UI/CSS related code, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
page.attributes.*
are nowpage.*
butpage.attributes.*
will still work until next major version.page.attributes.injectMarkdownHeadings
is nowpage.markdownHeadings
, so that this feature is consistent withpage.excerpt
.saber-plugin-query-posts
categories and tags are injected aspage.categoriesInfo
andpage.tagsInfo
becausepage.categories
andpage.tags
are already used in front matter due to the changes made in(1)
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
Published PR with canary version:
Canary Versions
extract-sfc-blocks@0.0.3-canary.345.d76e516.0
create-blog@0.2.8-canary.345.d76e516.0
create-site@0.3.2-canary.345.d76e516.0
saber-highlight-css@0.0.6-canary.345.d76e516.0
saber-highlighter-prism@0.3.2-canary.345.d76e516.0
saber-log@0.2.1-canary.345.d76e516.0
saber-markdown@0.0.10-canary.345.d76e516.0
saber-plugin-feed@0.3.5-canary.345.d76e516.0
saber-plugin-git-modification-time@0.0.4-canary.345.d76e516.0
saber-plugin-google-analytics@0.0.7-canary.345.d76e516.0
saber-plugin-image@0.0.5-canary.345.d76e516.0
saber-plugin-meta-redirect@0.0.6-canary.345.d76e516.0
saber-plugin-netlify-redirect@0.0.7-canary.345.d76e516.0
saber-plugin-prismjs@0.2.2-canary.345.d76e516.0
saber-plugin-pwa@0.3.4-canary.345.d76e516.0
saber-plugin-query-posts@0.3.3-canary.345.d76e516.0
saber-plugin-transformer-html@0.0.6-canary.345.d76e516.0
saber-plugin-transformer-pug@0.0.6-canary.345.d76e516.0
saber-utils@0.1.6-canary.345.d76e516.0
saber@0.6.11-canary.345.d76e516.0
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor