Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: disable service worker #350

Closed
saltysugar opened this issue Jul 27, 2019 · 4 comments · Fixed by #351
Closed

Feature request: disable service worker #350

saltysugar opened this issue Jul 27, 2019 · 4 comments · Fixed by #351
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt

Comments

@saltysugar
Copy link
Contributor

saltysugar commented Jul 27, 2019

Issuehunt badges

Feature request

What problem does this feature solve?

I was using saber-plugin-pwa but now I no longer need the PWA feature.

What does the proposed API look like?

- resolve: saber-plugin-pwa
  options:
    disabled: true

How should this be implemented in your opinion?

When disabled: true, this plugin registers a service worker to uninstall previously installed service worker.

Are you willing to work on this yourself?

Yes 😄


IssueHunt Summary

saltysugar saltysugar has been rewarded.

Backers (Total: $60.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@krmax44
Copy link
Contributor

krmax44 commented Jul 27, 2019

Maybe the current service worker could be changed so that it removes itself when an update is applied without saber-plugin-pwa. The removal of the plugin should cause the removal of the service worker, the disabled option feels a bit clunky.

@issuehunt-oss
Copy link

issuehunt-oss bot commented Jul 27, 2019

@issuehunt has funded $60.00 to this issue.


@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jul 27, 2019
@Kelier
Copy link

Kelier commented Aug 6, 2019

Loop over those registrations and all the registration object's unregister function?

navigator.serviceWorker.getRegistrations().then(

    function(registrations) {

        for(let registration of registrations) {  
            registration.unregister();

        }

});

@issuehunt-oss
Copy link

issuehunt-oss bot commented Aug 20, 2019

@egoist has rewarded $42.00 to @saltysugar. See it on IssueHunt

  • 💰 Total deposit: $60.00
  • 🎉 Repository reward(20%): $12.00
  • 🔧 Service fee(10%): $6.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants