Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: disable service worker #350

Closed
saltysugar opened this issue Jul 27, 2019 · 4 comments

Comments

@saltysugar
Copy link
Contributor

commented Jul 27, 2019

Issuehunt badges

Feature request

What problem does this feature solve?

I was using saber-plugin-pwa but now I no longer need the PWA feature.

What does the proposed API look like?

- resolve: saber-plugin-pwa
  options:
    disabled: true

How should this be implemented in your opinion?

When disabled: true, this plugin registers a service worker to uninstall previously installed service worker.

Are you willing to work on this yourself?

Yes 😄


IssueHunt Summary

saltysugar saltysugar has been rewarded.

Backers (Total: $60.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@krmax44

This comment has been minimized.

Copy link
Member

commented Jul 27, 2019

Maybe the current service worker could be changed so that it removes itself when an update is applied without saber-plugin-pwa. The removal of the plugin should cause the removal of the service worker, the disabled option feels a bit clunky.

@issuehunt-app

This comment has been minimized.

Copy link

commented Jul 27, 2019

@issuehunt has funded $60.00 to this issue.


@saltysugar saltysugar referenced this issue Jul 28, 2019
3 of 18 tasks complete
@Kelier

This comment has been minimized.

Copy link

commented Aug 6, 2019

Loop over those registrations and all the registration object's unregister function?

navigator.serviceWorker.getRegistrations().then(

    function(registrations) {

        for(let registration of registrations) {  
            registration.unregister();

        }

});

@egoist egoist closed this in #351 Aug 20, 2019

@issuehunt-app

This comment has been minimized.

Copy link

commented Aug 20, 2019

@egoist has rewarded $42.00 to @saltysugar. See it on IssueHunt

  • 💰 Total deposit: $60.00
  • 🎉 Repository reward(20%): $12.00
  • 🔧 Service fee(10%): $6.00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.