Invoke a hook before/after generating a page

[egoist]

Feature request

What problem does this feature solve?

Would be useful for https://github.com/egoist/saber/issues/71

What does the proposed API look like?

api.hooks.afterGeneratePage.tapPromise(ID, context => {
  const amp = shouldGenerateAMPPage(context)
  if (amp) {
    //...
  }
})

How should this be implemented in your opinion?

N/A

Are you willing to work on this yourself?

PR welcome.

marchworks earned $20.00 by resolving this issue!

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on Issuehunt to raise funds.

[IssueHuntBot]

@IssueHunt has funded $20.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[nblthree]

@egoist where should beforeGeneratePage event be emited I am not sure maybe here for production
https://github.com/egoist/saber/blob/38fe0a48b382854456a4b58c4dd253229bb17885/packages/saber/vue-renderer/lib/index.js#L296
and here for the dev
https://github.com/egoist/saber/blob/38fe0a48b382854456a4b58c4dd253229bb17885/packages/saber/lib/plugins/source-pages.js#L97
I can't find where to emit it for both

[egoist]

after generating a page, probably here: https://github.com/egoist/saber/blob/38fe0a48b382854456a4b58c4dd253229bb17885/packages/saber/vue-renderer/lib/index.js#L279

[nblthree]

I added a console.log there but it doesn't get executed in dev mode

[egoist]

yes, ssr is for production only, in dev it runs as a spa

[nblthree]

https://github.com/egoist/saber/issues/107#issuecomment-488584989

btw probably we should allow to run app in SSR in dev mode, useful for debugging.

should I await this or what?

[egoist]

nope, that's not our top priority, and it will be an optional feature.

[nblthree]

so I have done

await this.api.hooks.beforeGeneratePage.promise(context)
await fs.outputFile(route.outputFilePath, html, 'utf8')
await this.api.hooks.afterGeneratePage.promise(context)

here https://github.com/egoist/saber/blob/38fe0a48b382854456a4b58c4dd253229bb17885/packages/saber/vue-renderer/lib/index.js#L279 which work fine in the build process for the dev mode I am not sure if this is the right place https://github.com/egoist/saber/blob/38fe0a48b382854456a4b58c4dd253229bb17885/packages/saber/vue-renderer/lib/index.js#L411

[egoist]

we don't need this hook in dev mode

[IssueHuntBot]

@egoist has rewarded $14.00 to @marchworks. See it on IssueHunt

• 💰 Total deposit: $20.00
• 🎉 Repository reward(20%): $4.00
• 🔧 Service fee(10%): $2.00