Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for unwanted extensions in the NZB #1513

Closed
Safihre opened this issue Jun 18, 2020 · 2 comments · Fixed by #1515
Closed

Check for unwanted extensions in the NZB #1513

Safihre opened this issue Jun 18, 2020 · 2 comments · Fixed by #1515

Comments

@Safihre
Copy link
Member

Safihre commented Jun 18, 2020

Supported by: https://forums.sabnzbd.org/viewtopic.php?f=3&t=24804

We only check inside the rar-files if there are unwanted extensions.. but what if they are just as a file inside the main NZB? We should detect those to.

@sanderjo
Copy link
Contributor

sanderjo commented Jun 18, 2020

WIP: Detection is working, and failing works too, but in an ugly way ...

EDIT: Oh, wait, this post is very special: one very big EXE, plus par2 files. So when my prototype threw away the EXE, ... the download failed completely correctly. Let met check with a download with rar and par2 files, plus some "handy"codec.exe ...

image

@sanderjo
Copy link
Contributor

With the same code, and a fabricated with EXE in plain sight, and the rest just in plain RARs (NZB here: https://raw.githubusercontent.com/sanderjo/NZBs/master/reftestnzb_small_post_with_EXE_as_plain_file.nzb ), the code works quite nicely:

  • On NZB import, the EXE file is skipped, with a warning.
  • The rest is imported, and succesfully downloaded.

@Safihre I just skip the EXE (and other unwanted extensions). No pausing. I see that as the only feasible to do, without too much code overhauling.

image

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants