Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use walrus operator, removing Python 3.7 support #2394

Closed
Safihre opened this issue Dec 31, 2022 · 5 comments
Closed

Use walrus operator, removing Python 3.7 support #2394

Safihre opened this issue Dec 31, 2022 · 5 comments

Comments

@Safihre
Copy link
Member

Safihre commented Dec 31, 2022

I would like to start using the new walrus operator that was introduced in Python 3.8.
This would break Python 3.7 support for the next major SABnzbd release.
The official EOL for Python 3.7 is in a few months, so doesn't seem like a big problem?
I also saw that Ubuntu uses Python 3.8 in 20.04 LTS so we are good there.
Anything I'm overlooking here?

@thezoggy
Copy link
Contributor

thezoggy commented Dec 31, 2022

Hopefully in this docker relevant world we won't be held back by nas with outdated python... But jcfp for example hacks back in py3.6 support for his ppa. So he might be the best sounding board on why not to do it.

@sanderjo
Copy link
Contributor

But jcfp for example hacks back in py3.6 support for his ppa.

Possibly because:

Ubuntu 18.04 is still supported until April 30, 2023 (so 4 more months)
Ubuntu 18.04 has Python3.6

@sanderjo
Copy link
Contributor

About walrus operator:

>>> a=5
>>> if (b:=a+100) > 10: print(b)
... 
105
>>> 

Ah, so finally the C assignment + value in Python? Good.

And "walrus" because of the long teeth in ":=" ?

@jcfp
Copy link
Member

jcfp commented Jan 1, 2023

jcfp for example hacks back in py3.6 support for his ppa. So he might be the best sounding board on why not to do it.

Don't let that get in the way of progress. The end of the distro's support windows for those old OS releases is approaching fast anyway; any remaining users will just have to enjoy sab 3.7.1 until they finally decide to update.

@Safihre
Copy link
Member Author

Safihre commented Jan 1, 2023

Thanks for the input 👍 will go ahead with the changes.

@Safihre Safihre closed this as completed Jan 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants