Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorter bug #2654

Closed
ItsME6969 opened this issue Aug 13, 2023 · 5 comments
Closed

Sorter bug #2654

ItsME6969 opened this issue Aug 13, 2023 · 5 comments
Labels

Comments

@ItsME6969
Copy link

The sorter thinks its a multiple episode release when the episode name starts with a number in the range of the actual episode number +2 e.g
Show.Name.1969.S01E02.2.Kings.1080p.......DDP5.1.H.264 --> S01E02
Show.Name.1969.S01E02.3.Kings.1080p.......DDP5.1.H.264 --> S01E02-03
Show.Name.1969.S01E02.4.Kings.1080p.......DDP5.1.H.264 --> S01E02-04
Show.Name.1969.S01E02.5Kings.1080p.......DDP5.1.H.264 --> S01E02

I cleared out the logs but with season packs the capitalization is still hit and miss with {%sn (%y)/%sn (%y) - S%0se%0e}.%ext

@jcfp
Copy link
Member

jcfp commented Aug 14, 2023

It's actually guessit doing that:

Python 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import guessit
>>> guessit.api.guessit('Show.Name.1969.S01E02.2.Kings.1080p.DDP5.1.H.264')
MatchesDict([('title', 'Show Name'), ('year', 1969), ('season', 1), ('episode', 2), ('episode_title', '2 Kings'), ('screen_size', '1080p'), ('audio_codec', 'Dolby Digital Plus'), ('audio_channels', '5.1'), ('video_codec', 'H.264'), ('type', 'episode')])
>>> guessit.api.guessit('Show.Name.1969.S01E02.3.Kings.1080p.DDP5.1.H.264')
MatchesDict([('title', 'Show Name'), ('year', 1969), ('season', 1), ('episode', [2, 3]), ('episode_title', 'Kings'), ('screen_size', '1080p'), ('audio_codec', 'Dolby Digital Plus'), ('audio_channels', '5.1'), ('video_codec', 'H.264'), ('type', 'episode')])

How realistic is it for a multi-ep or season pack job to have an episode title?

@Safihre
Copy link
Member

Safihre commented Aug 15, 2023

I will close this as an upstream problem, there's just very little we can do about it.
You could open an issue: https://github.com/guessit-io/guessit/issues
Unfortunately the project seems a bit stale at the moment..

@Safihre Safihre closed this as completed Aug 15, 2023
@jcfp
Copy link
Member

jcfp commented Aug 15, 2023

I'll file it anyway, this seems fixable on their end by using the presence of an episode title as a counter-indication for applying this specific handling of a potential multi-ep result.

@Safihre
Copy link
Member

Safihre commented Aug 15, 2023

Thanks!

@ItsME6969
Copy link
Author

ItsME6969 commented Aug 16, 2023

I bundled 2 bugs in this one report but the Season Packs still don't get proper capitalization.

2023-08-16 06:54:06,106::DEBUG::[filesystem:877] Renaming "....Show.Name.S01.1080p.../Show Name - S01e08.mkv" to "show name/Show Name - S01e08.mkv".

{%sn (%y)/%sn (%y) - S%0se%0e}.%ext
this is the sort string I have so everything so should be lowercase, and it shows as lowercase in the preview, but when it actually processes the files, they end up mixed case.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants