Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sabnzbd icon not visible on dark mode in macOS Sierra #698

Closed
Safihre opened this issue Oct 4, 2016 · 5 comments
Closed

Sabnzbd icon not visible on dark mode in macOS Sierra #698

Safihre opened this issue Oct 4, 2016 · 5 comments
Assignees
Milestone

Comments

@Safihre
Copy link
Member

Safihre commented Oct 4, 2016

Reported on forum and on reddit, since I don't have Mac someone else needs to check this 馃槈

There's a bug in macOS Sierra. When you use dark mode the menu bar icon which shows the speed and time left for a download is in black font so it doesn't show. Here's a screen shot to show what I am talking about.
http://imgur.com/a/6V6KJ

@Safihre Safihre added this to the 1.1.1 milestone Oct 4, 2016
@shypike shypike self-assigned this Oct 4, 2016
@shypike
Copy link
Member

shypike commented Oct 4, 2016

The font color should probably be revered. The main issue is how to find out whether this "dark mode" has been enabled in the first place. At worst we could add a "special" to set it.

@iandol
Copy link

iandol commented Oct 27, 2016

defaults read -g AppleInterfaceStyle returns Dark so does work on macOs Sierra when in dark mode, but I think requires spawning a shell process from Python. The other method suggested was:

center = NSDistributedNotificationCenter.defaultCenter()
center.addObserver_selector_name_object_(self,"enableDarkMode",'AppleInterfaceThemeChangedNotification',None)

I'm not a python programmer so can't test if this works.

@shypike
Copy link
Member

shypike commented Oct 27, 2016

As soon as I have upgraded to Sierra, I'll try.
It works fine on El Capitan.

@Safihre Safihre modified the milestones: 1.2.0, 1.1.1 Nov 24, 2016
@Safihre
Copy link
Member Author

Safihre commented Dec 16, 2016

It seems Apple has fixed some bug in latest Sierra updates, because on both my machines it works again (also for SABnzbd 1.1.1).
Closing this!

@Safihre Safihre closed this as completed Dec 16, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants