Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't upgrade to fastapi==0.88.0 because "fastapi-mail 1.2.2 depends on starlette<0.22.0" #161

Closed
ilBEastli opened this issue Dec 6, 2022 · 10 comments 路 Fixed by #174
Closed

Comments

@ilBEastli
Copy link

The same problem as in previous issue #157 but for the next version of the library.
Do you consider to make less restrictive version dependency? 馃檹馃徎

@elpacificmb
Copy link
Contributor

For your code to work, you need to force your requirements.txt to fastapi==0.86.0 and starlette==0.20.4, with that in place, you will have no issue for now.

@ilBEastli
Copy link
Author

Yep but it keeps me and other users on old versions of libraries. That's pretty sad :(

@gbiz123
Copy link

gbiz123 commented Dec 17, 2022

I was able to resolve this with pip install fastapi=0.87.0 in a virtual environment

@ssproessig-thales
Copy link

maybe solved with #167

@theshohidul
Copy link

Could you please consider making a less restrictive version dependency?

@sabuhish
Copy link
Owner

Hi there! could you guys please check version 1.2.4?

@rambo
Copy link
Contributor

rambo commented Jan 10, 2023

The caret version specifier is overly strict for 0.x versions, see python-gino/gino-starlette#38 for details.

I also do not understand why python version is set to ^3.8.1 I could understand some much higher patch revision of 3.8 if it was really needed but .1 ?

edit: found the reason, flake8 is being difficult

@rememberlenny
Copy link

Can we go to 0.89.*?

@rambo
Copy link
Contributor

rambo commented Jan 25, 2023

@rememberlenny my PR hasvery loose starlette requirements (and there is no explicit requirement for fastapi version, the issues come from starlette version binds).

@sabuhish
Copy link
Owner

sabuhish commented Jan 29, 2023

@rambo if your statements prove it I would be pleased about it, I thought I made it less restrictive on fastapi, but it seems like this issue arises again and again. Thanks for your work, will release a new version of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants