New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't upgrade to fastapi==0.88.0 because "fastapi-mail 1.2.2 depends on starlette<0.22.0" #161
Comments
For your code to work, you need to force your requirements.txt to fastapi==0.86.0 and starlette==0.20.4, with that in place, you will have no issue for now. |
Yep but it keeps me and other users on old versions of libraries. That's pretty sad :( |
I was able to resolve this with pip install fastapi=0.87.0 in a virtual environment |
maybe solved with #167 |
Could you please consider making a less restrictive version dependency? |
Hi there! could you guys please check version 1.2.4? |
The caret version specifier is overly strict for 0.x versions, see python-gino/gino-starlette#38 for details. I also do not understand why python version is set to ^3.8.1 I could understand some much higher patch revision of 3.8 if it was really needed but .1 ? edit: found the reason, flake8 is being difficult |
Can we go to 0.89.*? |
@rememberlenny my PR hasvery loose starlette requirements (and there is no explicit requirement for fastapi version, the issues come from starlette version binds). |
@rambo if your statements prove it I would be pleased about it, I thought I made it less restrictive on fastapi, but it seems like this issue arises again and again. Thanks for your work, will release a new version of the library. |
The same problem as in previous issue #157 but for the next version of the library.
Do you consider to make less restrictive version dependency? 馃檹馃徎
The text was updated successfully, but these errors were encountered: