Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQTT subscription topic matching does not conform to spec #46

Closed
plundeen opened this issue Jan 11, 2023 · 2 comments
Closed

MQTT subscription topic matching does not conform to spec #46

plundeen opened this issue Jan 11, 2023 · 2 comments

Comments

@plundeen
Copy link

The FastMQTT.match function does not handle wildcards according to the MQTT specification. Per Section 4.7.1.2:

"sport/#" also matches the singular "sport", since # includes the parent level.

But the FastMQTT.match() method would not consider "sport" a match on the wildcard'ed subscription "sport/#".
@sabuhish
Copy link
Owner

sabuhish commented Feb 5, 2023 •
edited

Hello, did your PR solve the issue you had? I was talking about this PR #47

@plundeen
Copy link
Author

plundeen commented Feb 5, 2023

Yes, thanks!

@plundeen plundeen closed this as completed Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sabuhish @plundeen