Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't click outside job details dialog to close it #8

Open
crutchcorn opened this issue Apr 12, 2024 · 1 comment
Open

Can't click outside job details dialog to close it #8

crutchcorn opened this issue Apr 12, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@crutchcorn
Copy link
Member

I should be able to click outside of a dialog to close it:

dialog_close

@crutchcorn crutchcorn added bug Something isn't working good first issue Good for newcomers labels Apr 12, 2024
@rusher2004
Copy link
Collaborator

rusher2004 commented Apr 12, 2024

An added detail, this ModalView component should take this as an optional property. There will be cases where we may want to disallow closing the modal on outside click or escape. For example, a form with a lot of fields. Users can get pretty frustrated if they lose a bunch of form details because they accidentally clicked outside the modal.

Like what shoelace does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants