Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redux setup is not correct #16

Closed
markerikson opened this issue Dec 10, 2021 · 2 comments · Fixed by #17
Closed

Redux setup is not correct #16

markerikson opened this issue Dec 10, 2021 · 2 comments · Fixed by #17

Comments

@markerikson
Copy link

Unfortunately, the Redux setup in this example project is not correct. It's still using the legacy Redux createStore API, using "hand-written" reducer logic with separate action constants, and following an outdated folder structure. Today we teach and recommend using "modern Redux" using our official Redux Toolkit package, the React-Redux hooks API, and a "feature folder" structure with a single "slice" file of Redux logic per feature.

Please see the "Redux Essentials" tutorial and the Redux Style Guide best practices page in our docs for our recommended approaches:

@sachie
Copy link
Owner

sachie commented Dec 11, 2021

@markerikson Thanks for bringing this to my attention. The new setup seems far neater to use!
I have removed the old redux structure and added an example with redux-toolkit in #17.

@markerikson
Copy link
Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants