You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Could you please check your Plugin.prototype.isVideo function? It seems there is a logical error which doesn't allow me to create dynamic HTML5 video player.
You do the following check if(!src) { throw new Error("Make sure that slide " + index + " has an image/video src"); }
and then the second one which will never happen if there is no src due to the first check if (!src && html) { return { html5: true }; }
BTW, thanks for the cool library!
The text was updated successfully, but these errors were encountered:
denhaidash
changed the title
Issue with dynamic videos
Issue with dynamic videos (isVideo function)
Oct 13, 2017
Hi!
Could you please check your Plugin.prototype.isVideo function? It seems there is a logical error which doesn't allow me to create dynamic HTML5 video player.
You do the following check
if(!src) { throw new Error("Make sure that slide " + index + " has an image/video src"); }
and then the second one which will never happen if there is no src due to the first check
if (!src && html) { return { html5: true }; }
BTW, thanks for the cool library!
The text was updated successfully, but these errors were encountered: