Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with dynamic videos (isVideo function) #76

Closed
denhaidash opened this issue Oct 13, 2017 · 2 comments
Closed

Issue with dynamic videos (isVideo function) #76

denhaidash opened this issue Oct 13, 2017 · 2 comments

Comments

@denhaidash
Copy link

Hi!

Could you please check your Plugin.prototype.isVideo function? It seems there is a logical error which doesn't allow me to create dynamic HTML5 video player.

You do the following check
if(!src) { throw new Error("Make sure that slide " + index + " has an image/video src"); }

and then the second one which will never happen if there is no src due to the first check
if (!src && html) { return { html5: true }; }

BTW, thanks for the cool library!

@denhaidash denhaidash changed the title Issue with dynamic videos Issue with dynamic videos (isVideo function) Oct 13, 2017
@rkimaoui
Copy link

for videos, i get this error too: Make sure that slide 0 has an image/video src

@sachinchoolur
Copy link
Owner

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants