Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entry name from npm registry for installation #2

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

machawk1
Copy link
Contributor

@machawk1 machawk1 commented Sep 7, 2021

I attempted to install the tool using the instructions in the README. When executing "npm install -g replace-jQuery", the response report 'replace-jQuery@*' is not in the npm registry.. However, "'replace-jquery" and it appears to be authored by @sachinchoolur, but perhaps npm dropped the capitalization.

Regardless, this PR changes the README to allow for installation based on the name in npm.

Copy link

@Amorymeltzer Amorymeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shell invocations should probably also be changed, e.g.

replace-jQuery src/sample.js out.js

to

replace-jquery src/sample.js out.js

etc.

@machawk1
Copy link
Contributor Author

machawk1 commented Sep 7, 2021

@Amorymeltzer The shell commands using camelcase (i.e., replace-jQuery) work as-is despite the package name, when installed from npm, requiring the name to be all lowercase.

@Amorymeltzer
Copy link

Sure. I figured it might as well match, esp. the executable, but it ain't a big deal.

@sachinchoolur sachinchoolur merged commit 9f59c67 into sachinchoolur:main Sep 7, 2021
@sachinchoolur
Copy link
Owner

Yes, it should be npm i replace-jquery https://www.npmjs.com/package/replace-jquery

Thank you 👍🏻

@machawk1 machawk1 deleted the patch-1 branch September 7, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants