Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

startOf(DurationUnit.week) and endOf(DurationUnit.week) errors #13

Closed
libwiki opened this issue Oct 18, 2023 · 2 comments
Closed

startOf(DurationUnit.week) and endOf(DurationUnit.week) errors #13

libwiki opened this issue Oct 18, 2023 · 2 comments
Assignees
@sadespresso
Labels
improvement

Comments

@libwiki
Copy link

libwiki commented Oct 18, 2023 •
edited
Loading

startOf(DurationUnit.week) and endOf(DurationUnit.week) errors

  • moment_dart: ^1.0.1
image

I just noticed the startOfLocalWeek method. Maybe the above is not the problem.
@sadespresso sadespresso self-assigned this Oct 18, 2023
@sadespresso
Copy link
Owner

Thank you for reporting the issue.

Moment.startOf(DurationUnit.week) should return startOfLocalWeek

Same story for endOf

I will be pushing a fix very soon

@sadespresso
Copy link
Owner

It's fixed in 1.1.0

Moment.startOf(DurationUnit.week) uses Moment.defaultLocalization.weekStart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sadespresso sadespresso

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@libwiki @sadespresso