Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple listings of MBE8M VST in REAPER #105

Closed
frescoalfredo opened this issue May 16, 2020 · 10 comments
Closed

Multiple listings of MBE8M VST in REAPER #105

frescoalfredo opened this issue May 16, 2020 · 10 comments
Assignees
Labels
bug Something isn't working HOTFIX The change will first appear in the 'hotfix' branch over the 'master' branch
Milestone

Comments

@frescoalfredo
Copy link

This happens with 1.1.21 binary Linux VST files from SourceForge, and also happened with 1.1.19 (but I assumed at the time it was because I had built the plugins and done something wrong during the build).

In the effects browser of the Linux version of REAPER, there are 8 entries of "Multiband Expander Mono x8" instead of separate entries for the various mono/stereo/lr/midside versions. See image 1 attached. (Only MBE8M exists multiple times, not the other variants.)

I did a clear cache/re-scan of plugins. The same thing happened.

Loading all those plugins shows they are all just the same plugin (Multiband Expander Mono x8).

Examining the reaper-vstplugins64.ini file (which has all the plugin listings for the 64-bit vst plugins), it seems the listing of those particular plugins is inconsistent from one part of the line to the next. See image 2 attached.

I then edited the reaper-vstplugins64.ini file, removing all lines containing lsp_plugins*. A fresh scan of the plugins then resulted in the same duplication.

I then edited the reaper-vstplugins64.ini file, changing the second part of each line to be like the first part of the line (the first line for example, I renamed "Multiband Expander Mono x8" to "Multiband Expander LeftRight x8" (etc.) That didn't work. I then gave each plugin a unique number (since I notice that number "757935405" was for every one of those plugins, so I arbitrarily added 1 to each subsequent plugin listing). The effects browser then showed multiples of "Multiband Expander Mono x8" but now also seemingly the other versions. Loading all the Multiband Expander plugins though, despite the different plugin names in the window title bars, each plugin had the same blue LSP button that says "LSP MBE8M" (and only 1 in/out for the routing) confirming it's all just the same plugin.

It seems the reaper-vstplugins64.ini file keeps getting re-generated with the erroneous listings, based on what the plugins are reporting to REAPER during a scan.

VST plugin references are contained in other REAPER ini files as well, but only for their names (for the sake of sorting into folders/favorites), so changing those files has no effect on this.

mbexm_1

mbexm_2

@sadko4u
Copy link
Collaborator

sadko4u commented May 16, 2020

The problem is, that I forgot to register Multiband Expander on the Steinberg site. All plugins have the same 4-character VST identifier.

Why didn't you report the problem before I've just released 1.1.21?

@sadko4u sadko4u self-assigned this May 16, 2020
@sadko4u sadko4u added the bug Something isn't working label May 16, 2020
@sadko4u sadko4u added this to the 1.2.0 milestone May 16, 2020
@frescoalfredo
Copy link
Author

My apologies! I didn't even notice the mistake at first (when building the pre-release version with the bugfix for the previous issue). I only realized this a week or so later when trying that plugin for the first time. I don't normally use expansion plugins. Since I'm new to building anything in Linux, I thought I had made a mistake when building 1.1.19. I assumed when you released 1.1.21, I'd download the binaries and it would be "proper" and not "broken like the ones that I built wrong". :-/

@sadko4u
Copy link
Collaborator

sadko4u commented May 16, 2020

It's my mistake too that I forgot to register VST2 identifiers. Anyway thanks that you've found that problem. Since it's a simple problem, it's very sad that it has not been included into 1.1.21 release.
Here's the change that will fix the problem: 8011a70

@sadko4u
Copy link
Collaborator

sadko4u commented May 16, 2020

Added this patch to the hotfix branch so distro builders can include it into build scripts: 84bef7a

@sadko4u sadko4u added PENDING FOR RELEASE This issue will be added to the nearest upcoming release HOTFIX The change will first appear in the 'hotfix' branch over the 'master' branch labels May 16, 2020
@frescoalfredo
Copy link
Author

I wish I'd have tested a previous version to confirm this, once I saw the problem in the version I built...but I tend to blame myself more often than others when I'm doing something new. I was a Windows user for too long. Becoming a Linux user is taking me a bit of time. :-)

@sadko4u
Copy link
Collaborator

sadko4u commented May 17, 2020

Please confirm that all is OK now if it is possible for you to build from sources.

@frescoalfredo
Copy link
Author

I successfully built the VST plugins with no errors, tested them and confirm this issue is resolved. Thanks!

@frescoalfredo
Copy link
Author

frescoalfredo commented May 17, 2020

UNRELATED and maybe not a bug (but I figure I should mention it now just in case):

Are the Compressor and Dynamics Processor plugins supposed to report lookahead to the DAW?

Normally if a plugin requests some lookahead from REAPER, REAPER will compensate automatically and display the number of samples (and the buffer size) required, right in the fx browser window for the plugin and in the performance meter. I don't see this, but I do hear a difference in the sound.

If I've misunderstood what the lookahead feature means, I apologize. :) I notice in the Limiter that it does request plugin delay compensation from REAPER, for instance.

@sadko4u
Copy link
Collaborator

sadko4u commented May 17, 2020

No, according to the code currently none of the dynamic processor plugins does not report latency.
Please create another issue.

@sadko4u sadko4u modified the milestones: 1.2.0, 1.1.20, 1.1.22 May 18, 2020
@sadko4u sadko4u removed the PENDING FOR RELEASE This issue will be added to the nearest upcoming release label May 31, 2020
@sadko4u
Copy link
Collaborator

sadko4u commented May 31, 2020

Available in 1.1.22 release!

@sadko4u sadko4u closed this as completed May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working HOTFIX The change will first appear in the 'hotfix' branch over the 'master' branch
Projects
None yet
Development

No branches or pull requests

2 participants