Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All filters are not always being reset #7

Closed
brentrobbins opened this issue Oct 3, 2023 · 7 comments
Closed

All filters are not always being reset #7

brentrobbins opened this issue Oct 3, 2023 · 7 comments

Comments

@brentrobbins
Copy link

I noticed in the demo when you select a filter and also use the Title search/filter, once you click on reset; the filter value is not fully reset and still is preset in the URL. Here's a quick screencast top to show you what I am running into.

CleanShot.2023-10-03.at.15.34.17.mp4

By the way, thank you so much @kavinvalli & @sadmann7 for creating this. I found it while watching your livecode247 channel on youtube. It has been very helpful and exactly what I have been looking for. 🙏🏻

@sadmann7
Copy link
Owner

sadmann7 commented Oct 8, 2023

Thanks for the issue.

I will look into it

@CyanFlare
Copy link

Hello,
Any updates on this issue? I'm having the same issue with the filters not fully being reset.

@iaingymware
Copy link

Any update on this please or is this now a dead repo?

@maykon-oliveira
Copy link

Same problem

@dewodt
Copy link
Contributor

dewodt commented Dec 17, 2023

Same here.

@dewodt
Copy link
Contributor

dewodt commented Dec 18, 2023

I have tried fixing it in pull request #13. Maybe @sadmann7 @kavinvalli can review my pull request. Thank you.

@sadmann7
Copy link
Owner

sadmann7 commented Jan 1, 2024

Thanks a lot @dewodt.

Closing this issue.

@sadmann7 sadmann7 closed this as completed Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants