Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a keep_sound toggle #11

Open
2 tasks
Tracked by #6
sadnow opened this issue Dec 26, 2021 · 1 comment
Open
2 tasks
Tracked by #6

Add a keep_sound toggle #11

sadnow opened this issue Dec 26, 2021 · 1 comment
Assignees
@sadnow
Labels
enhancement New feature or request
Milestone
Audio Syncing

Comments

@sadnow
Copy link
Owner

sadnow commented Dec 26, 2021 •
edited

This would also keep_duration. Feature originally attempted in d8d62fd but abandoned due to confusing coding practices

  • Add compatbility for Method B first
  • Method A compatibility

For implementing Method A compatibility, see the ffmpeg examples on https://github.com/xinntao/Real-ESRGAN/blob/master/docs/anime_video_model.md
@sadnow sadnow added the enhancement New feature or request label Dec 26, 2021
@sadnow sadnow self-assigned this Dec 26, 2021
@sadnow sadnow mentioned this issue Dec 26, 2021
Closed
11 tasks
@sadnow sadnow closed this as completed Dec 26, 2021
@sadnow sadnow reopened this Dec 26, 2021
@sadnow sadnow added this to the "Keep Source Audio" Option milestone Dec 26, 2021
@sadnow sadnow mentioned this issue Dec 26, 2021
Open
2 tasks
@sadnow
Copy link
Owner Author

sadnow commented Dec 26, 2021

Partial unfinished implementation in 5405a8e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sadnow sadnow

Labels
enhancement New feature or request
Projects
None yet
Milestone
Audio Syncing
Development

No branches or pull requests
1 participant
@sadnow