Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined nvd3-efforts #1

Closed
5 tasks done
nomego opened this issue Mar 14, 2016 · 3 comments
Closed
5 tasks done

Combined nvd3-efforts #1

nomego opened this issue Mar 14, 2016 · 3 comments
Assignees

Comments

@nomego
Copy link
Contributor

nomego commented Mar 14, 2016

Hi!

I would like to propose that we combine our development efforts with nvd3 Polymer elements!

We've published an nvd3-pie element at https://github.com/Neovici/nvd3-pie with a different feature set but the same general goal.

The things we would want to get into your behavior or specific elements would be:

  • Possibility to (multi) select graph slices/parts (with bound selected or similar and/or events)
  • Configurable x/y label/value properties (to avoid re-mapping input data)
  • Support title
  • Support tooltips
  • Support growOnHover

Also I would probably consider using iron-resize and refresh() method instead of nv.utils.windowResize() helper to also react on resize-events within the page and not only the window.

If you think these are features/changes you'd welcome into your repository we can fork your repo and start working on PRs for this.
Any feature you'd want to implement yourself of these?
They are available (although they can be made more elegant) in our element right now if you want to have a look.

Thanks and hope we can work together on this!

@saeidzebardast
Copy link
Owner

Dear Patrik,

Thank you for your suggestions. I've implemented the following features based on your request and released v0.13.0:

  • title (nvd3-donut)
  • growOnHover (nvd3-pie, nvd3-donut)

For other features, you're welcome to open pull requests. I'll merge them ASAP.
I hope we can work together on this to implement more features.

@nomego
Copy link
Contributor Author

nomego commented Mar 17, 2016

Great!

We'll get working on PRs soon, probably tomorrow or next week!

@saeidzebardast
Copy link
Owner

All features are available on 0.17.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants