Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code proposal #8

Open
SamGG opened this issue Apr 19, 2020 · 0 comments
Open

Code proposal #8

SamGG opened this issue Apr 19, 2020 · 0 comments

Comments

@SamGG
Copy link

SamGG commented Apr 19, 2020

Hi Sofie,

Does the gsub mean basename? At

CytoNorm/R/QuantileNorm.R

Lines 494 to 495 in e94732c

paste0(prefix,
gsub(".*/","",file)))))

I think it you would interesting to store the untransformed along with the transformed channels. This redundant with the quantile plot but this will allow the user to see the transform with a classical flow software. I mean something like copying original expression of the transformed channels, renaming the colnames, and fr_append_cols them before wirting.

By the way, as the current process replaces the expression but do not alter the range, I wonder if there could be a problem if the transformed maximum is higher than the previous as the range does not change. This might be linked to previous issues.

Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant