Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push notifications for signing transactions #1079

Closed
4 of 5 tasks
DmitryBespalov opened this issue Nov 17, 2020 · 3 comments
Closed
4 of 5 tasks

Push notifications for signing transactions #1079

DmitryBespalov opened this issue Nov 17, 2020 · 3 comments
Assignees
@elgatovital
Labels
enhancement
Milestone
Sprint 18 "Rancagua"

Comments

@DmitryBespalov
Copy link
Collaborator

DmitryBespalov commented Nov 17, 2020 •
edited by elgatovital

Changes to the push notification registration

  • Generate UUID on the device and store it for push notification requests
  • Implement hashing of the registration request
  • Add timestamp and signatures fields to the registration request with the signature of the imported owner key (if present)
  • Send registration request after:
    • first safe was added
    • cloud messaging token updated
    • safe added
    • safe removed
    • owner key imported
    • owner key removed
  • Support receiving new CONFIRMATION_REQUEST notification
    • type: CONFIRMATION_REQUEST
    • address: safe address checksummed
    • safeTxHash: transaction hash to open when a push notification is tapped

See the specification for more details: https://docs.google.com/document/d/1RqIfZkqdS_TZ4IQVjeWUhNI1ZguD3NfpohSSRLVxB5Q/edit#
@elgatovital elgatovital self-assigned this Nov 17, 2020
@elgatovital elgatovital mentioned this issue Nov 19, 2020
Merged
@DmitryBespalov DmitryBespalov added this to the Sprint 17 "..." milestone Nov 24, 2020
@elgatovital
Copy link
Contributor

notification title & text

Confirmation required
<safe_name>: A transaction requires your confirmation!

@liliya-soroka
Copy link
Member

Back-end task - safe-global/safe-transaction-service#190

@liliya-soroka
Copy link
Member

Verified
2.7.0 - 1664rc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elgatovital elgatovital

Labels
enhancement
Projects
None yet
Milestone
Sprint 18 "Rancagua"
Development

No branches or pull requests
4 participants
@DmitryBespalov @liliya-soroka @tschubotz @elgatovital