Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad Coingecko API query param #753

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix bad Coingecko API query param #753

merged 1 commit into from
Oct 17, 2023

Conversation

hectorgomezv
Copy link
Member

@hectorgomezv hectorgomezv commented Oct 16, 2023 •
edited

  • Fixes the Coingecko query param to hold the ERC20 contract addresses when retrieving prices (bug introduced in this commit)

@hectorgomezv hectorgomezv self-assigned this Oct 16, 2023
@hectorgomezv hectorgomezv requested a review from a team as a code owner October 16, 2023 15:46
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6536026105

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 91.395%
Totals Coverage Status
Change from base Build 6532782637: 0.05%
Covered Lines: 4802
Relevant Lines: 5127
💛 - Coveralls

@hectorgomezv hectorgomezv added the bug Something isn't working label Oct 16, 2023
@hectorgomezv hectorgomezv changed the title Fix bad Coingecko API header key Fix bad Coingecko API query param Oct 17, 2023
@hectorgomezv hectorgomezv merged commit d3de47a into main Oct 17, 2023
16 checks passed
@hectorgomezv hectorgomezv deleted the fix-bad-coingecko-api-header branch October 17, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmrsabino fmrsabino fmrsabino approved these changes

Assignees

@hectorgomezv hectorgomezv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hectorgomezv @coveralls @fmrsabino