Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support EIP-1155 #106

Closed
rmeissner opened this issue Jun 21, 2019 · 0 comments
Closed

Support EIP-1155 #106

rmeissner opened this issue Jun 21, 2019 · 0 comments
Assignees
@rmeissner
Labels
enhancement
Milestone
contracts-safe-1.1.0

Comments

@rmeissner
Copy link
Member

rmeissner commented Jun 21, 2019 •
edited

EIP-1155 requires a contract that wants to receive tokens to implement a callback function. We need to provide the handling of this function.

Possible solutions

  • Implement callback directly on the safe contract, this would require that we change the master copy for any changes related to the callback
  • Add a fallback module that can be registered to handle different types of callback calls (this would also handle ERC777 support in MultiSigWallet and gnosis safe #104 and other future standards)

Links

Related issues

cc @cag @Georgi87 @Uxio0 @denisgranha
@rmeissner rmeissner self-assigned this Jun 21, 2019
@rmeissner rmeissner added this to the contracts-safe-1.1.0 milestone Jun 21, 2019
farreldarian pushed a commit to farreldarian/safe-contracts that referenced this issue Jan 14, 2024
@germartinez
Merge pull request safe-global#106 from gnosis/multisend-fix
6cf3be1 
Multisend fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmeissner rmeissner

Labels
enhancement
Projects
None yet
Milestone
contracts-safe-1.1.0
Development

No branches or pull requests
1 participant
@rmeissner