Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5.0 Release changes #599

Merged
merged 16 commits into from
Aug 1, 2023
Merged

1.5.0 Release changes #599

merged 16 commits into from
Aug 1, 2023

Conversation

akshay-ap and others added 2 commits June 30, 2023 15:29
* WIP: EIP-1271 fix

* Fix lint issue

* Fix bytes32 test by signing hash instead of pre-image

* EIP-1271: Fix failing test case for 0xExploit

* EIP-1271: Comment data param in function call

* EIP-1271: Fix lint issue

* Remove use of outdated EIP-1271 method specification.

* [#391] Add comment in natspec regarding unused data parameter

---------

Co-authored-by: Mikhail <mveehkim@gmail.com>
* add setup and rules about modules

* fix run script

* use solc7.6 for fv

* Mark assembly blocks as memory-safe

* use solidity 0.8.19 for github action benchmark

* Update makefile

* fix the harness patch

* properties doc skeleton

* properties notes

* use 10m optimizer runs

* Write calldata/return data to the memory allocated via the free memory pointer

* memory-safe simulateAndRevert

* Update CLA github action to v2.3.0

* add certora workflow

* Fix changelog mention of createChainSpecificProxyWithNonce

* fix script path

* use cvl2

* Remove gasleft in setupModules, add erc4337 compatibility test

* Fix typechecking in test files (#573)

* verify that guard can only be updated through setGuard

* Verify functions that may change the fallback handler address (#566)

* Add an invariant for singleton address (#565)

* Add an optimistic assumption about DELEGATECALL, update nonce monotonicity rule (#574)

* Pump version to 1.4.1 (#579)

* Formal verification: native token balance updates (#582)

* Add an optimistic assumption about DELEGATECALL, update nonce monotonicity rule

* Add a rule for token balance

* Add more rules for native token balance transition

* Fix addresses for 1.4.1 in changelog (#590)

* Fix certora CI action

* Formal verification: No message can be signed through the core contract (#583)

* Add a rule for no signed messages

* Add a rule for no signed messages

* fix munged patch

---------

Co-authored-by: teryanarmen <61996358+teryanarmen@users.noreply.github.com>
Co-authored-by: Uxio Fuentefria <Uxio0@users.noreply.github.com>
Co-authored-by: Francisco Giordano <fg@frang.io>
Co-authored-by: Richard Meissner <rmeissner@users.noreply.github.com>
Co-authored-by: Mikhail Mikheev <mmv@pop-os.localdomain>
@mmv08 mmv08 requested review from a team, rmeissner, Uxio0 and akshay-ap and removed request for a team June 30, 2023 13:31
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5423487370

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 93.988%

Totals Coverage Status
Change from base Build 5400554544: -0.07%
Covered Lines: 314
Relevant Lines: 329

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jun 30, 2023

Pull Request Test Coverage Report for Build 5726842109

  • 24 of 32 (75.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.2%) to 93.191%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/examples/guards/DebugTransactionGuard.sol 0 2 0.0%
contracts/examples/guards/DelegateCallTransactionGuard.sol 0 2 0.0%
contracts/examples/guards/ReentrancyTransactionGuard.sol 0 4 0.0%
Totals Coverage Status
Change from base Build 5726828518: -2.2%
Covered Lines: 320
Relevant Lines: 340

💛 - Coveralls

@mmv08 mmv08 force-pushed the release/v1.5.0 branch 3 times, most recently from 157b833 to 6610267 Compare June 30, 2023 14:53
@mmv08 mmv08 marked this pull request as ready for review June 30, 2023 15:05
@mmv08
Copy link
Member Author

mmv08 commented Jul 6, 2023

Added a do not merge label because more features are planned

@safe-global safe-global deleted a comment Jul 19, 2023
* Alternative implmentation for module guard

* Fix lint error

* Update interfaceId for Guard

* d tests

* Update guardmanager interface

---------

Co-authored-by: Mikhail <mveehkim@gmail.com>
akshay-ap and others added 3 commits August 1, 2023 13:09
* Add overloaded checkNSignatures

* add legacy checknsignatures tests

---------

Co-authored-by: Mikhail <mveehkim@gmail.com>
@mmv08 mmv08 removed the do not merge label Aug 1, 2023
@mmv08 mmv08 merged commit e22af08 into main Aug 1, 2023
12 checks passed
@mmv08 mmv08 deleted the release/v1.5.0 branch August 1, 2023 13:12
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants