Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade certora spec files and CI to certora-cli v6 #732

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Jan 16, 2024

This PR updates the certora cli to the latest available v6 version. The main breaking change is that ghosts have to be marked persistent if we don't want them to be HAVOC'ed on, let's say, an external call.

Copy link

Pull Request Test Coverage Report for Build 7543498216

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.397%

Totals Coverage Status
Change from base Build 7542362512: 0.0%
Covered Lines: 396
Relevant Lines: 404

💛 - Coveralls

@mmv08 mmv08 marked this pull request as draft January 16, 2024 16:54
@mmv08
Copy link
Member Author

mmv08 commented Jan 16, 2024

I'm converting this to a draft because the update to v6 broke the ownerSignaturesAreProvidedForExecTransaction rule. Presumably, because the tool behaves non-deterministically for abi.encodePacked (or a hash of it) even for the same data. The certora team's investigating.

Example run: https://prover.certora.com/output/6575/96223f29578f4584b7e1afa6c4356ce8/?anonymousKey=b4c7ff82200f16cc7d24b33fca4948008693a3a7

@coveralls
Copy link

coveralls commented Feb 5, 2024

Pull Request Test Coverage Report for Build 7785684151

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on certora/v6-spec-update at 94.397%

Totals Coverage Status
Change from base Build 7609222733: 94.4%
Covered Lines: 396
Relevant Lines: 404

💛 - Coveralls

@mmv08 mmv08 requested review from a team, rmeissner, nlordell, akshay-ap and remedcu and removed request for a team February 5, 2024 11:10
@mmv08 mmv08 marked this pull request as ready for review February 5, 2024 11:12
@mmv08 mmv08 merged commit 3da1415 into main Feb 5, 2024
20 checks passed
@mmv08 mmv08 deleted the certora/v6-spec-update branch February 5, 2024 14:18
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants