Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename repository to safe-smart-account #733

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Rename repository to safe-smart-account #733

merged 5 commits into from
Jan 22, 2024

Conversation

akshay-ap
Copy link
Member

Fixes #719

Changes in PR:

  • Find and replace all instances of safe-contracts with safe-smart-account

@akshay-ap akshay-ap self-assigned this Jan 17, 2024
@akshay-ap akshay-ap marked this pull request as draft January 17, 2024 13:09
@coveralls
Copy link

coveralls commented Jan 17, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7584813704

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.397%
Totals Coverage Status
Change from base Build 7542362512: 0.0%
Covered Lines: 396
Relevant Lines: 404
💛 - Coveralls

nlordell
nlordell reviewed Jan 17, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@akshay-ap akshay-ap marked this pull request as ready for review January 18, 2024 08:28
@akshay-ap akshay-ap requested review from rmeissner, mmv08, remedcu, a team and nlordell and removed request for a team January 18, 2024 13:46
remedcu
remedcu reviewed Jan 19, 2024
View reviewed changes
Copy link
Member

@remedcu remedcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be changed as well from Safe Contracts to Safe Smart Account?

https://github.com/safe-global/safe-contracts/blob/feature-719-rename-repository/contracts/common/StorageAccessible.sol#L7
https://github.com/safe-global/safe-contracts/blob/feature-719-rename-repository/contracts/handler/CompatibilityFallbackHandler.sol#L10
https://github.com/safe-global/safe-contracts/blob/feature-719-rename-repository/contracts/libraries/Enum.sol#L5
https://github.com/safe-global/safe-contracts/blob/feature-719-rename-repository/contracts/libraries/SafeStorage.sol#L5

remedcu
remedcu reviewed Jan 19, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
remedcu
remedcu approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@remedcu remedcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small ones, but rest LGTM 👍🏾

akshay-ap and others added 2 commits January 19, 2024 15:04
@akshay-ap @remedcu
Update README.md
57e140b 
Co-authored-by: Shebin John <admin@remedcu.com>
@akshay-ap @remedcu
Update contracts/libraries/SafeStorage.sol
4c77602 
Co-authored-by: Shebin John <admin@remedcu.com>
@nlordell nlordell merged commit 914d0f8 into main Jan 22, 2024
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
@mmv08 mmv08 deleted the feature-719-rename-repository branch January 22, 2024 09:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlordell nlordell nlordell approved these changes

@mmv08 mmv08 mmv08 approved these changes

@remedcu remedcu remedcu approved these changes

@rmeissner rmeissner Awaiting requested review from rmeissner

Assignees

@akshay-ap akshay-ap

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename the repo to safe-smart-account
5 participants
@akshay-ap @coveralls @nlordell @mmv08 @remedcu