Add support for hooks in multisignature flow. #46
Comments
akshay-ap
added a commit
that referenced
this issue
Jul 26, 2023
akshay-ap
added a commit
that referenced
this issue
Jul 26, 2023
3 tasks
akshay-ap
added a commit
that referenced
this issue
Aug 2, 2023
akshay-ap
added a commit
that referenced
this issue
Aug 3, 2023
akshay-ap
added a commit
that referenced
this issue
Aug 3, 2023
akshay-ap
added a commit
that referenced
this issue
Aug 9, 2023
akshay-ap
added a commit
that referenced
this issue
Aug 14, 2023
akshay-ap
added a commit
that referenced
this issue
Aug 15, 2023
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 15, 2023
* [#46] Implement Guard interface in SafeProtocolManager * [#46] Setup Safe * [#46] Fix EOF * [#46] User setupTest function * [#46] Fix lint issue * [#46] Add tests * [#46] Add test with delegateCall for hooks flow * [#46] User temporary variable for storing hooks address * [#47] Use ZeroAddress from ethers * [#46] Reset tempHooksAddress * [#46] Refactor tests for SafeProtocolManager as Guard * [#46] Fix failing test * [#46] Update comment * Update test/SafeProtocolManager.spec.ts Co-authored-by: Mikhail <mveehkim@gmail.com> * [#46] Use setupTests() function --------- Co-authored-by: Mikhail <mveehkim@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 22, 2023
* [#46] Implement Guard interface in SafeProtocolManager * [#47] Create FunctionHandlerManager.sol and inherit in SafeProtocolManager * [#47] Create BaseManager contract, rename modifier, rename error, check registry while adding function handler * [#47] Update natspec doc * [#46] Setup Safe * [#46] Fix EOF * [#46] User setupTest function * [#46] Fix lint issue * [#46] Add tests * [#46] Add test with delegateCall for hooks flow * [#46] User temporary variable for storing hooks address * [#47] Implement logic for non-static calls to function handler manager, test to set function handler * [#47] Add tests for Function Handler * [#47] Pass sender address in handle function * [#47] Fix test * [#47] Use ZeroAddress from ethers * [#46] Reset tempHooksAddress * [#47] Test static call to function handler * [#47] Fix lint issue * [#47] Fix typo * [#46] Refactor tests for SafeProtocolManager as Guard * [#46] Fix failing test * [#46] Update comment * [#47] Update tests for Function Handler * [#47] Update tests for function handler * [#47] Remove test function handler from .solcover.js * [#47] Return data from handle function * [#47] Verify call data passed to handle(...) * [#47] Update doc string * [#47] Check if function handler is whitelisted * [#47] Make fallback function non-payable, optimize codesize * [#47] Fix lint issue * [#47] Add ERC165 check while adding function handler * [#47] Allow only self calls to manager * [#47] Add tests for function handler * [#47] Add tests * [#47] Rename function to `checkCallerisSender()` * [#47] Rename to OnlyAccountCallable, add docstrings * [#47] Update string in describe * [#47] Update natspec doc for RegistryManager constructor * [#47] Update natspec doc for FunctionHandlerManager
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 22, 2023
* [#46] Implement Guard interface in SafeProtocolManager * [#47] Create FunctionHandlerManager.sol and inherit in SafeProtocolManager * [#47] Create BaseManager contract, rename modifier, rename error, check registry while adding function handler * [#47] Update natspec doc * [#46] Setup Safe * [#46] Fix EOF * [#46] User setupTest function * [#46] Fix lint issue * [#46] Add tests * [#46] Add test with delegateCall for hooks flow * [#46] User temporary variable for storing hooks address * [#47] Implement logic for non-static calls to function handler manager, test to set function handler * [#47] Add tests for Function Handler * [#47] Pass sender address in handle function * [#47] Fix test * [#47] Use ZeroAddress from ethers * [#46] Reset tempHooksAddress * [#47] Test static call to function handler * [#47] Fix lint issue * [#47] Fix typo * [#46] Refactor tests for SafeProtocolManager as Guard * [#46] Fix failing test * [#46] Update comment * [#47] Update tests for Function Handler * [#47] Update tests for function handler * [#47] Remove test function handler from .solcover.js * [#47] Return data from handle function * [#47] Verify call data passed to handle(...) * [#47] Update doc string * [#47] Check if function handler is whitelisted * [#47] Make fallback function non-payable, optimize codesize * [#47] Fix lint issue * [#53] Registry checks for hooks * [#53] Remove chained assignments * [#53] Fix failing tests * [#53] Remove chained assignments * [#53] Update comment on using temp hooks address * [#53] Update data sent as parameter to pre-check hook in checkModuleTransaction, update natspec
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 23, 2023
* [#46] Implement Guard interface in SafeProtocolManager * [#47] Create FunctionHandlerManager.sol and inherit in SafeProtocolManager * [#47] Create BaseManager contract, rename modifier, rename error, check registry while adding function handler * [#47] Update natspec doc * [#46] Setup Safe * [#46] Fix EOF * [#46] User setupTest function * [#46] Fix lint issue * [#46] Add tests * [#46] Add test with delegateCall for hooks flow * [#46] User temporary variable for storing hooks address * [#47] Implement logic for non-static calls to function handler manager, test to set function handler * [#47] Add tests for Function Handler * [#47] Pass sender address in handle function * [#47] Fix test * [#47] Use ZeroAddress from ethers * [#46] Reset tempHooksAddress * [#47] Test static call to function handler * [#47] Fix lint issue * [#47] Fix typo * [#46] Refactor tests for SafeProtocolManager as Guard * [#46] Fix failing test * [#46] Update comment * [#47] Update tests for Function Handler * [#47] Update tests for function handler * [#47] Remove test function handler from .solcover.js * [#47] Return data from handle function * [#47] Verify call data passed to handle(...) * [#47] Update doc string * [#47] Check if function handler is whitelisted * [#47] Make fallback function non-payable, optimize codesize * [#47] Fix lint issue * [#47] Add ERC165 check while adding function handler * [#47] Allow only self calls to manager * [#47] Add tests for function handler * [#47] Add tests * [#47] Rename function to `checkCallerisSender()` * [#47] Rename to OnlyAccountCallable, add docstrings * [#47] Update string in describe * [#47] Update natspec doc for RegistryManager constructor * [#47] Update natspec doc for FunctionHandlerManager * [#73] Check if plugin supports expected interface Id when enabling * [#73] Fix lint issue * [#73] Add test for Manager: block EOA as Plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It should be possible to register the Manager contract as a guard on the Safe and then execute hooks when a multisignature transaction is executed.
References:
Note: the execution data has not been finalized, but for an initial version it should contain all the parameters from the
execTransactioncall.The text was updated successfully, but these errors were encountered: