Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: remove references to a Safe{Core} Protocol account as Safe #100

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Sep 11, 2023

This PR is an addition to 5afe/safe-core-protocol-specs#38

As discussed earlier, we believe the protocol should be account-agnostic (as long as the account implements the required API by the spec). We often called the account used in the protocol a safe. This PR fixes this and replaces it with a generic account name.

@mmv08 mmv08 requested review from a team, rmeissner, Uxio0 and akshay-ap and removed request for a team September 11, 2023 16:19
@zeroknots
Copy link

Very much appreciate this!

akshay-ap

This comment was marked as duplicate.

akshay-ap

This comment was marked as duplicate.

docs/execution_flows.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Pull Request Test Coverage Report for Build 6247187262

  • 40 of 40 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6224134414: 0.0%
Covered Lines: 181
Relevant Lines: 181

💛 - Coveralls

@akshay-ap
Copy link
Contributor

Fixes #105

@akshay-ap akshay-ap force-pushed the feat/remove-isafe-from-function-parameters branch from 3fd8d78 to 0e41056 Compare September 20, 2023 09:15
@akshay-ap akshay-ap added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit a015cd4 Sep 21, 2023
5 checks passed
@akshay-ap akshay-ap deleted the feat/remove-isafe-from-function-parameters branch September 21, 2023 14:01
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants