Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the prepack command to build js files, bump version #112

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

mmv08
Copy link
Member

@mmv08 mmv08 commented Sep 28, 2023

This PR:

  • In the 0.3.0-alpha.0 version, the dist folder wasn't published and therefore installing the package errored
  • The build command used in the prepack lifecycle didn't build the javascript files, this pr fixes this

@mmv08 mmv08 requested review from a team, rmeissner, Uxio0 and akshay-ap and removed request for a team September 28, 2023 10:30
@github-actions
Copy link

Pull Request Test Coverage Report for Build 6337696273

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6326592942: 0.0%
Covered Lines: 187
Relevant Lines: 187

💛 - Coveralls

@mmv08 mmv08 added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit c61d6e8 Sep 28, 2023
5 checks passed
@mmv08 mmv08 deleted the bug-npm-missing-main-js-file branch September 28, 2023 12:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants