-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 Add Cexes Comparison Section #429
base: main
Are you sure you want to change the base?
Conversation
export const Cex = ({ boxes, boxColor, name, message }: CEX) => ( | ||
<div className={css.cex}> | ||
<div className={css.cexGrid}> | ||
{[...Array(boxes)].map((_, index) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: to save the spread, we can instantiate the array with the length of boxes
, e.g.
{[...Array(boxes)].map((_, index) => ( | |
{Array.from({ length: boxes },.map((_, index) => ( |
const textMotionProps = { | ||
initial: { opacity: 0, y: -10 }, | ||
whileInView: { opacity: 1, y: 0 }, | ||
viewport: { once: true }, | ||
transition: { | ||
type: 'spring', | ||
stiffness: 260, | ||
damping: 20, | ||
}, | ||
} | ||
|
||
const gridMotionProps = { | ||
initial: { scale: 0, x: -10 }, | ||
whileInView: { scale: 1, x: 0 }, | ||
viewport: { once: true }, | ||
transition: { | ||
type: 'spring', | ||
stiffness: 260, | ||
damping: 20, | ||
}, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I'd add the type to these from motion.div
for safety.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename the folder -> AssetsSecured
@@ -49,6 +49,32 @@ | |||
"href": "https://dune.com/queries/3737066" | |||
} | |||
}, | |||
{ | |||
"component": "DataRoom/Cexes", | |||
"label": "CEX", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use caption
here
Why aren't you fetching the values dynamically? |
Related to #382