Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3365 fix typed data issue #3374

Merged
merged 1 commit into from
Dec 18, 2023
Merged

GH-3365 fix typed data issue #3374

merged 1 commit into from
Dec 18, 2023

Conversation

DmitryBespalov
Copy link
Collaborator

@DmitryBespalov DmitryBespalov commented Dec 18, 2023

Handles #3365

Changes proposed in this pull request:

  • MetaMask doesn't produce correct signature if the 'data' in the "0x" format. When it is an empty string, the signature is correct.
  • Other wallets seem to support the empty string "" as well.

@DmitryBespalov DmitryBespalov self-assigned this Dec 18, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 761 lines in your changes are missing coverage. Please review.

Comparison is base (2b3ddf0) 8.14% compared to head (6793ee2) 8.03%.
Report is 24 commits behind head on main.

Files Patch % Lines
...Connect to Web/Logic/WebConnectionController.swift 0.00% 234 Missing ⚠️
...sViewController/TransactionDetailCellBuilder.swift 0.00% 102 Missing ⚠️
Multisig/Logic/Models/EIP712Transformer.swift 0.00% 70 Missing ⚠️
...cureConfig/Sources/SecureConfig/SecureConfig.swift 0.00% 59 Missing ⚠️
... Web/Logic/WebConnectionToSessionTransformer.swift 0.00% 49 Missing ⚠️
...ntroller/ReviewSafeTransactionViewController.swift 0.00% 49 Missing ⚠️
...Connect to Web/Logic/WebConnectionRepository.swift 0.00% 44 Missing ⚠️
...let/UI/SendTransactionToWalletViewController.swift 0.00% 19 Missing ⚠️
...isig/Cross-layer/Configuration/Configuration.swift 0.00% 17 Missing ⚠️
Multisig/App/SceneDelegate.swift 0.00% 16 Missing ⚠️
... and 19 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3374      +/-   ##
========================================
- Coverage   8.14%   8.03%   -0.11%     
========================================
  Files        786     788       +2     
  Lines      43371   43946     +575     
========================================
  Hits        3532    3532              
- Misses     39839   40414     +575     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryBespalov DmitryBespalov merged commit 05f17b7 into main Dec 18, 2023
3 checks passed
@DmitryBespalov DmitryBespalov deleted the GH-3365/fix-metamask branch December 18, 2023 13:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants